Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: release workflows [IDE-155] #434

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

bastiandoetsch
Copy link
Contributor

@bastiandoetsch bastiandoetsch commented Mar 1, 2024

Description

  • Removed Amplitude telemetry and corresponding setting from VSCode

Checklist

  • Tests added and all succeed
  • Linted
  • CHANGELOG.md updated
  • README.md updated, if user-facing

Screenshots / GIFs

Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!

@bastiandoetsch bastiandoetsch requested a review from a team as a code owner March 1, 2024 08:32
Comment on lines +3 to +6
## [2.3.6
### Changes
- Removed Amplitude telemetry and corresponding setting from VSCode

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the idea of this PR and #432 to remove everything related to Amplitude?
Would we need to remove also code related to @amplitude/ampli and @amplitude/experiment-node-server?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Experiment service is different from the other analytics, we can still use it for canary/feature flag services.

@bastiandoetsch bastiandoetsch enabled auto-merge (squash) March 1, 2024 09:05
@bastiandoetsch bastiandoetsch merged commit 91ed2c4 into main Mar 1, 2024
6 checks passed
@bastiandoetsch bastiandoetsch deleted the fix/IDE-155_remove_ampli_from_workflows branch March 1, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants